[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases #15895

jaclync · 2025-07-10T20:13:55Z

Just one review is required.

Description

This pull request introduces a new method refreshEligibility(ineligibleReason:) to POSEntryPointEligibilityCheckerProtocol with basic implementation in POSTabEligibilityChecker to handle eligibility state updates based on specific ineligible reasons. Site settings related cases and the POS feature switch disabled case are covered in this PR. Unsupported WC plugin version case will be supported separately in WOOMOB-799.

Eligibility refresh logic:

WooCommerce/Classes/POS/Controllers/POSEntryPointController.swift: Updated the refreshEligibility method to accept an ineligibleReason parameter and use posEligibilityChecker for eligibility state updates.
WooCommerce/Classes/POS/Presentation/PointOfSaleEntryPointView.swift: Modified the POSIneligibleView refresh action to pass the reason parameter to the posEntryPointController.refreshEligibility method.

Protocol and implementation updates:

WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSTabEligibilityChecker.swift: Added the refreshEligibility method to the POSEntryPointEligibilityCheckerProtocol and implemented it in POSTabEligibilityChecker to handle various ineligible reasons, including syncing site settings remotely and checking eligibility again. checkEligibility currently just includes one API request to reload the POS feature switch value, the site settings and WC plugin values are synced outside of the eligibility checker from site initialization. [1] [2]

Error handling and site settings synchronization:

WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSTabEligibilityChecker.swift: Introduced the POSTabEligibilityCheckerError enum for error handling, including a selfDeallocated case. Added the syncSiteSettingsRemotely method to synchronize site settings and refresh eligibility state. [1] [2]

Legacy checker adjustments:

WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/LegacyPOSTabEligibilityChecker.swift: Added a refreshEligibility method with an assertion failure for unsupported refresh operations in the legacy POS tab implementation.

Steps to reproduce

Unsupported store currency

Prerequisite: for a store that is eligible for POS, change the currency in core under WC settings > General to a different value

Launch the app with the site in the prerequisite --> the POS tab should appear shortly
Tap on the POS tab --> after the loading state, an ineligible screen should be shown about the unsupported currency
Tap Retry --> the CTA should be in loading state, then back to normal state
In wp-admin, update the store currency to the supported value
Back in the app, tap Retry --> the CTA should be in loading state, then the app enters POS

POS feature switch disabled

Prerequisite: for a store that is eligible for POS and with WC version 10.0+, disable the POS feature in WooCommerce settings > Advanced > Features

Launch the app with the site in the prerequisite --> the POS tab should appear shortly
Tap on the POS tab --> after the loading state, an ineligible screen should be shown about the disabled POS feature
Tap Retry --> the CTA should be in loading state, then back to normal state
In wp-admin, enable the feature switch
Back in the app, tap Retry --> the CTA should be in loading state, then the app enters POS

Testing information

I tested the above cases, and when the device is offline.

Screenshots

Unsupported store currency

Simulator.Screen.Recording.-.iPad.A16.-.2025-07-10.at.15.15.40.mp4

POS feature switch disabled

Simulator.Screen.Recording.-.iPad.A16.-.2025-07-10.at.15.20.10.mp4

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…ityCheckerProtocol` with basic implementation in `POSTabEligibilityChecker`.

wpmobilebot · 2025-07-10T20:23:00Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr15895-793a492`
	Version	`22.7`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`793a492`
	Installation URL	32876tnf8rmt8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

… refresh is supported.

joshheald

Works well, 🚢 – thanks!

joshheald · 2025-07-11T10:50:04Z

WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSTabEligibilityChecker.swift

+    func syncSiteSettingsRemotely() async throws {
+        try await withCheckedThrowingContinuation { [weak self] (continuation: CheckedContinuation<Void, Error>) in
+            guard let self else {
+                return continuation.resume(throwing: POSTabEligibilityCheckerError.selfDeallocated)
+            }
+            stores.dispatch(SettingAction.synchronizeGeneralSiteSettings(siteID: siteID) { [weak self] error in
+                guard let self else {
+                    return continuation.resume(throwing: POSTabEligibilityCheckerError.selfDeallocated)
+                }
+                if let error {
+                    return continuation.resume(throwing: error)
+                }
+                siteSettings.refresh()
+                continuation.resume(returning: ())
+            })
+        }
+    }


Do you think we could/should start defining these sorts of things in Yosemite? It's not as good as full async, but better than potentially writing this much nested code more than once. The errors would have to be generic, and we might need to pass in stores, but that seems potentially OK?

Not thought this through particularly thoroughly though. There's a good chance we'd be better off investing time in making Yosemite more async friendly. Nothing to do in this PR 😊

Good question. Definitely would be nice to create better interface in Yosemite for the POS use case, though sometimes there's already quite some logic in the Yosemite Store implementation. In general, I've been creating new APIs in Yosemite if it's something that doesn't exactly exist in a Yosemite Store. For something that's already available in a Yosemite Store, I still reuse it.

Would like to get your thought on the naming of the new APIs in Yosemite. WDYT about creating POS{Entity}Service for {Entity}Store in Yosemite? Currently, we have POSOrderService, POSReceiptService, POSEligibilityService behind their own protocol in Yosemite. I can make this change separately.

jaclync · 2025-07-11T14:02:39Z

Merging this first to unblock other refresh behavior work, will likely make changes separately for #15895 (comment).

jaclync added 3 commits July 10, 2025 15:18

Add refreshEligibility(ineligibleReason:) to `POSEntryPointEligibil…

2adc901

…ityCheckerProtocol` with basic implementation in `POSTabEligibilityChecker`.

Move site settings sync function to the appropriate section.

5ce0a9f

Update TODO comment for refreshing WC plugin.

f3fa930

jaclync changed the title ~~Add refreshEligibility method to POSTabEligibilityChecker~~ [POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch cases Jul 10, 2025

jaclync changed the title ~~[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch cases~~ [POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases Jul 10, 2025

jaclync added type: task An internally driven task. feature: POS labels Jul 10, 2025

jaclync modified the milestones: 22.8, 22.9 Jul 10, 2025

jaclync added 2 commits July 10, 2025 17:00

Add test cases for refreshEligibility.

b730d95

Update ineligible UI copy to not mention relaunching the app now that…

793a492

… refresh is supported.

jaclync requested review from iamgabrielma, joshheald and staskus July 10, 2025 21:44

joshheald self-assigned this Jul 11, 2025

joshheald approved these changes Jul 11, 2025

View reviewed changes

jaclync merged commit 2eac0e1 into trunk Jul 11, 2025
15 checks passed

jaclync deleted the feat/WOOMOB-757-refresh-eligibility branch July 11, 2025 14:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases #15895

[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases #15895

Uh oh!

jaclync commented Jul 10, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 10, 2025 •

edited

Loading

Uh oh!

joshheald left a comment

Uh oh!

joshheald Jul 11, 2025

Uh oh!

jaclync Jul 11, 2025

Uh oh!

jaclync commented Jul 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases #15895

[POS as a tab i2] Refresh POS eligibility in ineligible UI: site settings and feature switch disabled cases #15895

Uh oh!

Conversation

jaclync commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Eligibility refresh logic:

Protocol and implementation updates:

Error handling and site settings synchronization:

Legacy checker adjustments:

Steps to reproduce

Unsupported store currency

POS feature switch disabled

Testing information

Screenshots

Unsupported store currency

POS feature switch disabled

Uh oh!

wpmobilebot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshheald left a comment

Choose a reason for hiding this comment

Uh oh!

joshheald Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jaclync Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

jaclync commented Jul 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jaclync commented Jul 10, 2025 •

edited

Loading

wpmobilebot commented Jul 10, 2025 •

edited

Loading